-
Notifications
You must be signed in to change notification settings - Fork 211
Added migration to remove total hk/ck stakes this interval #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sam0x17
merged 7 commits into
devnet-ready
from
migration/total-hk-ck-stakes-this-interval-clear
Apr 21, 2025
Merged
Added migration to remove total hk/ck stakes this interval #1539
sam0x17
merged 7 commits into
devnet-ready
from
migration/total-hk-ck-stakes-this-interval-clear
Apr 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamil-gadelshin
previously approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sam0x17
previously approved these changes
Apr 14, 2025
camfairchild
previously approved these changes
Apr 14, 2025
shamil-gadelshin
previously approved these changes
Apr 21, 2025
gztensor
requested changes
Apr 21, 2025
pallets/subtensor/src/migrations/migrate_remove_total_hotkey_coldkey_stakes_this_interval.rs
Outdated
Show resolved
Hide resolved
sam0x17
approved these changes
Apr 21, 2025
This was referenced Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
run-bittensor-e2e-tests
Runs Bittensor SDK and BTCLI tests
skip-cargo-audit
This PR fails cargo audit but needs to be merged anyway
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The TotalHotkeyColdkeyStakesThisInterval storage item doesn't exist anymore, but it existed previously and no migrations has been done to clean the storage.
There are ~102,000 entries stored on chain.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.